Re: [PATCH v1] Add vacuum_delay_point() to GiST empty-page deletion pass

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Paul Kim <mok03127(at)gmail(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: [PATCH v1] Add vacuum_delay_point() to GiST empty-page deletion pass
Date: 2026-07-21 22:35:01
Message-ID: al_0FcLuM46-2gMO@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 21, 2026 at 05:11:51PM +0500, Andrey Borodin wrote:
> On 21 Jul 2026, at 15:02, Paul Kim <mok03127(at)gmail(dot)com> wrote:
>> This is long-standing rather than a recent regression, so I'll leave the
>> question of back-patching to a committer. Note that on branches before
>> 18 vacuum_delay_point() takes no argument (the bool was added by
>> e5b0b0ce150), so a back-patch would drop the "false".
>
> I don't know whether we should back-patch this. But I think the decision
> should be aligned with the similar one in your GIN thread [0].

Adding Heikki in CC as the committer of the change that removed
vacuum_delay_point() would attract his attention more easily. Done so
now.

I'd argue that this does not feel like a backpatch is strictly
required here. It took somebody 7 years to notice the gap, and I
suspect that some AI tool has been used for the scanning analysis.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-07-21 22:38:03 Re: [PATCH] Fix memory leak in pg_config
Previous Message Michael Paquier 2026-07-21 22:28:31 Re: Change checkpoint‑record‑missing PANIC to FATAL