On Thu, Jul 09, 2026 at 11:10:18AM +0200, Peter Eisentraut wrote:
> I suggest that unless we can come up with a well-defined, robust, and
> well-documented API for these, they should be moved back to be internal to
> pgstat.c, and test_custom_var_stats.c can define its own helper functions.
> Maybe in the future, when we have more of these, some good API will emerge.
I am not enough attached to these two APIs to keep them published if
one feels that it is weird to have them; we are talking about only a
few lines of code duplicated between core and the test module. I
still find the separation cleaner as done on HEAD, but well that's
just one opinion.
Sami, what's your take?
--
Michael