| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | cca5507 <cca5507(at)qq(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Do not lock tables in get_tables_to_repack |
| Date: | 2026-07-20 10:19:52 |
| Message-ID: | al31_DPTruXg2Tw7@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2026-Jul-11, cca5507 wrote:
> Bharath Rupireddy wrote:
> > + table_oid = IndexGetRelation(child_oid, true);
> > + if (!OidIsValid(table_oid))
> > + continue;
> >
> > How about a short comment on why this is needed even with a lock on
> > the parent, since that lock doesn't cover lower-level leaves in a
> > multi-level partition tree?
>
> I think it's worth a comment, too. Patch LGTM.
Thanks, added that and pushed.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2026-07-20 10:45:31 | Re: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum |
| Previous Message | shveta malik | 2026-07-20 10:17:14 | Re: Support EXCEPT for TABLES IN SCHEMA publications |