Re: remove VersionedQuery support from psql tab completion

On Thu, Jul 02, 2026 at 06:17:38PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> This infrastructure was added by commit 722408bcd1 and was only ever used
>> for publications and subscriptions. Since we just bumped psql's minimum
>> supported version to v10, it's no longer used by anything. Furthermore, a
>> quick glance indicates there's nothing else that should use it. So, IMHO
>> we might as well remove it.
>
> This seems a little short-sighted. Do you think we'll never again
> make any catalog changes that affect tab completion? Admittedly,
> maybe all such cases will fall under what SchemaQuery is good for.
> But that's significantly harder to use, so I'm not really in a
> hurry to make that tradeoff.

That's what I thought at first, but given we didn't accumulate any other
uses in the ~8 years it was around, I think there's a reasonably good
chance it goes unused for quite a while longer. This was just a small bit
of cleanup; I'm fine with leaving it around if you want.

--
nathan