Re: [Patch] Fix typo in pg_stat_us_to_ms()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tatsuya Kawata <kawatatatsuya0913(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Patch] Fix typo in pg_stat_us_to_ms()
Date: 2026-07-02 23:26:07
Message-ID: akbzj8fI2cS4e01a@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 02, 2026 at 10:36:01PM +0900, Tatsuya Kawata wrote:
> While reading pgstatfuncs.c, I noticed a small inconsistency in
> pg_stat_us_to_ms().
>
> The function converts microseconds to milliseconds, but the parameter
> is named val_ms, which suggests the opposite direction.
>
> Attached is a trivial patch renaming the parameter to val_us.

Aha. Fun. Will fix, thanks.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-07-02 23:36:35 Re: add validations for required callbacks during pgstat_register_kind()
Previous Message Michael Paquier 2026-07-02 23:21:01 Re: GetBufferDescriptor() being called for local buffers from MarkBufferDirtyHint()