| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Prevent crash when calling pgstat functions with unregistered stats kind |
| Date: | 2026-07-02 03:27:18 |
| Message-ID: | akXalpb3zjPX3ZEl@bdtpg |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Ewan,
On Wed, Jul 01, 2026 at 04:20:39PM +0800, Ewan Young wrote:
> Thanks for the patch — nice catch, and the diagnosis looks right.
Thanks for looking at it!
> One small thing: in pgstat_snapshot_fixed(), the existing
> Assert(pgstat_is_kind_valid(kind)); becomes redundant after the new NULL
> check. A non-NULL kind_info already implies the kind is valid (that's the
> only way pgstat_get_kind_info() returns non-NULL), so the assert can never
> fire. Might as well drop it and keep just the fixed_amount one.
Yeah good catch, done in the attached.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Prevent-crash-when-calling-pgstat-functions-with-.patch | text/x-diff | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | zengman | 2026-07-02 03:40:17 | Re: (SQL/PGQ) Clean up orphaned properties when dropping a label |
| Previous Message | jian he | 2026-07-02 03:23:10 | Re: implement CAST(expr AS type FORMAT 'template') |