| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tristan Partin <tristan(at)partin(dot)io> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Add pg_stat_kind_info system view |
| Date: | 2026-06-24 04:12:09 |
| Message-ID: | ajtZGdJSnR534qKp@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 18, 2026 at 04:54:36PM +0000, Tristan Partin wrote:
> On Mon Jun 8, 2026 at 12:16 AM UTC, Michael Paquier wrote:
>> On Thu, Jun 04, 2026 at 04:59:00PM +0000, Tristan Partin wrote:
>>> I believe that I also captured this correctly in v2.
>>
>> No v2 of the patch has been attached. :D
>
> I am not a very smart person! :facepalm:
Thanks for the patch.
A small comment that I have is related to the use of the unaligned
output of in stats.sql, where I doubt that we'll have a stats kind
named with more characters than the existing ones. And there are a
bunch of bools, which would be easier to read if aligned.
"written_to_file" as attribute name of the SQL function is
inconsistent. "write_to_file" would be.
The rest looks pretty much OK, seen from here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gilles Darold | 2026-06-24 04:15:21 | Re: Global temporary tables |
| Previous Message | Chao Li | 2026-06-24 03:49:26 | psql: add tab completion for subscription wal_receiver_timeout |