Re: Fix contradictory comment for pgstat_slru_flush_cb()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix contradictory comment for pgstat_slru_flush_cb()
Date: 2026-06-22 23:29:20
Message-ID: ajnFUAo0iGCcx63c@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 22, 2026 at 10:00:58PM +0900, Shinya Kato wrote:
> The first paragraph has the return value backwards. The function
> returns true only when nowait is set and the lock could not be
> acquired, and false otherwise, as the second paragraph correctly
> states. The reversed paragraph is a leftover from f4d3ca421d9, which
> removed an unrelated sentence but not the surrounding text.
>
> The attached patch removes the incorrect first paragraph.

Looks like you are right here. Grabbed for later.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Smith 2026-06-22 23:40:47 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Christophe Pettus 2026-06-22 23:14:39 Re: The PostgreSQL C Dialect