| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ewan Young <kdbase(dot)hack(at)gmail(dot)com> |
| Cc: | Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: 004_timeline_switch TAP test may fail |
| Date: | 2026-06-16 23:31:23 |
| Message-ID: | ajHcy2e-xuba6fVU@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 16, 2026 at 06:51:48PM +0800, Ewan Young wrote:
> One small thing: the rest of this file uses count(*), so I'd write count(*) = 2
> rather than count(1) = 2 just for local consistency. And the comment reads a
> little better as something like "Wait until both standbys have
> connected to the primary",
> since by this point they've already started -- what we're waiting for is the
> connection.
Both queries work the same for this purpose, so any of them is fine.
The comment needs to be refined a bit, though.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-06-16 23:41:23 | Re: First draft of PG 19 release notes |
| Previous Message | Masahiko Sawada | 2026-06-16 23:27:49 | Re: [PATCH] Release replication slot on error in SQL-callable slot functions |