| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Sami Imseih <samimseih(at)gmail(dot)com>, m(dot)litsarev(at)postgrespro(dot)ru, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_stat_statements: Remove (errcode...) framing parentheses in erport(...) |
| Date: | 2026-06-26 05:31:20 |
| Message-ID: | aj4OqKRx-MABlXWw@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 25, 2026 at 02:05:10PM -0700, Bharath Rupireddy wrote:
> +1 to what's said above. The merge burden is real (recently it took me
> more than 30 minutes just to create patches for back-branches even
> though most of the code remains the same in the function being
> changed). IMHO, it's not worth the cycles.
The unnecessary backpatching noise it the most annoying part.
ereport() code may use multiple levels of parenthesis, and that tends
to make the handling of the conflicts across branches quite annoying.
Let's keep this code as it is.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajit Awekar | 2026-06-26 05:51:43 | Re: Continuous re-validation of session credentials |
| Previous Message | vignesh C | 2026-06-26 05:19:17 | Re: Proposal: Conflict log history table for Logical Replication |