Re: Fix unqualified catalog references in psql describe queries

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: Fix unqualified catalog references in psql describe queries
Date: 2026-06-10 01:57:16
Message-ID: aijEfGcHUJvqjzNj@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 09, 2026 at 09:08:50AM +0000, Bertrand Drouvot wrote:
> Now I wonder if we shoud not "protect" the operators too. They could also
> lead to wrong results (if not worst).

Kind of true. Still we have been pretty lax about the operators as
they also lead to less readable queries.

There was one spot missing with string_agg() two lines down one of the
pg_get_expr() changes. The spots for relation and function
qualifications are worth addressing anyway, and consistent with the
file style. Fixed the extra spot I have noticed, and applied the
result on HEAD.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Henson Choi 2026-06-10 02:09:16 LLVM JIT: any JIT-compiled query crashes (SIGILL) on a libLLVM 19 + ASAN build
Previous Message Michael Paquier 2026-06-10 01:18:40 Re: Fix DROP PROPERTY GRAPH "unsupported object class" error