| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
| Cc: | surya poondla <suryapoondla4(at)gmail(dot)com>, "violin0613(at)tju(dot)edu(dot)cn" <violin0613(at)tju(dot)edu(dot)cn>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: Fw: Re: heap_force_common in contrib/pg_surgery/heap_surgery.c has an off by one stack buffer overflow |
| Date: | 2026-06-05 06:57:06 |
| Message-ID: | aiJzQt3zRv7Dvm_4@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jun 05, 2026 at 08:17:15AM +0900, Michael Paquier wrote:
> At the end, the first pattern is an outlier, we don't need to worry
> about performance in pg_surgery, and we're talking about three lines
> of code in pg_surgery to change (two for include_this_tid, one for the
> assertion). With all that in mind, I'd just do a -1 conversion and
> call it a day. :)
Which implies something like the simpler patch attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| surgery-oneoff.patch | text/plain | 784 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-06-05 07:58:07 | Re: BUG #19508: pg_buffercache_pages() crashes the backend with an incompatible caller-supplied record definition |
| Previous Message | Srinath Reddy Sadipiralla | 2026-06-05 06:09:03 | Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API |