| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Postgres Cybrosys <postgres(at)cybrosys(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Make spelling consistent in waiteventset.c |
| Date: | 2026-05-14 16:05:56 |
| Message-ID: | agXy5JXrHSMM_dbh@momjian.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 6, 2026 at 03:17:52PM +0530, Postgres Cybrosys wrote:
> Hi,
>
> The four backend-specific paths in WaitEventSetWaitBlock()
> (epoll, kqueue, poll, and Windows) had identical-purpose comments
> with inconsistent spellings.
>
> Two comments used "writable" while the other two used "writeable".
>
> This patch standardizes the spelling to "writable" to match the
> surrounding text in the file.
>
> The WL_SOCKET_WRITEABLE macro is a public identifier and is left
> unchanged.
>
> Patch attached.
I went to apply this patch and then got stuck when filling out the
Author field, since the email name doesn't look like a person's name,
and I am uncomfortable committing something without a person's name and
I don't remember ever doing this. To be more concrete, without a name
there is no way to reference the original author in the future --- a
company name doesn't allow that.
I am willing to apply this patch with no author if that is what people
prefer, or we can just leave the C comment typo unfixed.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-05-14 16:25:11 | Re: Fix bug of COPY TO support partition table |
| Previous Message | Junwang Zhao | 2026-05-14 15:30:46 | Re: [SQL/PGQ] Early pruning for GRAPH_TABLE path generation |