| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Henson Choi <assam258(at)gmail(dot)com> |
| Cc: | SungJun Jang <sjjang112233(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, Tatsuo Ishii <ishii(at)postgresql(dot)org>, thomas(dot)munro(at)gmail(dot)com |
| Subject: | Re: Remove invalid SS2/SS3 handling from EUC-KR routines |
| Date: | 2026-05-13 05:14:50 |
| Message-ID: | agQIymqNr3pdVkqi@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 12, 2026 at 08:39:04PM +0900, Henson Choi wrote:
> One small observation: after this patch, EUC-KR's mb routines become
> structurally identical to UHC's (1-2 byte Korean, IS_HIGHBIT_SET-only
> branch, maxmblen=2), which is a nice consistency win and arguably the
> right shape for "Korean 1-2 byte EUC". Could be worth a one-liner in
> the commit message.
I unfortunately cannot read the PNG file added at the top of the
thread, and it is a bit hard to check what you are doing here.
I can however point out two things:
- the existence of src/test/locale/, which may be impacted by what you
are changing here. Perhaps we should try to modernize a bit this
area, so as tests can become easier each time we try to change the
conversion tables?
- the proposed patch has zero regression tests. This could be used to
check the behavior before *and* after the patch.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2026-05-13 05:19:36 | Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION |
| Previous Message | Kirill Reshke | 2026-05-13 05:07:56 | Re: Fix SPLIT PARTITION bound-overlap bug and other improvements |