| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | remove pg_spin_delay() from atomics code |
| Date: | 2026-05-05 17:52:37 |
| Message-ID: | afouZUH_eUkIj4i4@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While inspecting what 32-bit optimizations we had, I noticed this line in
atomics/arch-x86.h:
#elif defined(_MSC_VER) && defined(__x86_64__)
...which led me to rediscover what Thomas Munro had found a while back [0],
i.e., we aren't using the right x86_64 macro for MSVC in lots of places.
Upon further inspection, all of this pg_spin_delay() stuff seems to have
been unused since it was added in commit b64d92f1a5, so I'm guessing it's
just an implementation artifact that didn't get cleaned up.
Here's a patch to remove that dead code.
[0] https://postgr.es/m/CA%2BhUKGL8Hs-phHPugrWM%3D5dAkcT897rXyazYzLw-Szxnzgx-rA%40mail.gmail.com
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-remove-pg_spin_delay.patch | text/plain | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2026-05-05 17:54:23 | Re: Available disk space per tablespace |
| Previous Message | Masahiko Sawada | 2026-05-05 17:36:24 | Re: Support logical replication of DDLs, take2 |