| From: | Tomas Vondra <tomas(at)vondra(dot)me> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Andrei Lepikhov <lepihov(at)gmail(dot)com>, tharakan(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org, PG Bug reporting form <noreply(at)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: BUG #18885: ERROR: corrupt MVNDistinct entry - 2 |
| Date: | 2025-04-21 09:41:19 |
| Message-ID: | afb124fc-f595-4681-bae8-e11c1ff52305@vondra.me |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 4/16/25 06:11, David Rowley wrote:
> On Wed, 16 Apr 2025 at 01:16, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>> In any case, such rework seems out of scope for PG18 - it's much more
>> than a fix for the bug.
>
> This is the reason I stopped short of adjusting the code in the patch
> I proposed in [1]. Speaking of which, do you have any views on that?
> It seems much more likely that someone would have caught the issue
> being reported here when writing the patch or during review if there
> was some sort of documentation to mention the function can't handle
> duplicate GroupVarInfos.
>
> I'll look at that patch again in the next few days with aims to push
> it unless someone has something to say about it.
>
Yeah, you're right the estimate_multivariate_ndistinct() comments should
have mentioned that the GroupVarInfos are expected to be unique ... and
perhaps there could have been some assert to check that.
regards
--
Tomas Vondra
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-04-21 10:08:18 | RE: Disabled logical replication origin session causes primary key errors |
| Previous Message | Shlok Kyal | 2025-04-21 06:40:51 | Re: BUG #18897: Logical replication conflict after using pg_createsubscriber under heavy load |