| From: | 'Alvaro Herrera' <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2026-05-01 07:30:27 |
| Message-ID: | afRWQlulXB6R3uNm@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 2026-Apr-07, Hayato Kuroda (Fujitsu) wrote:
> 01.
> ```
> --- a/src/backend/access/index/genam.c
> +++ b/src/backend/access/index/genam.c
> @@ -394,6 +394,14 @@ systable_beginscan(Relation heapRelation,
> SysScanDesc sysscan;
> Relation irel;
>
> + /*
> + * If this backend promised that it won't access shared catalogs during
> + * logical decoding, this it the right place to verify.
> + */
> + Assert(!HistoricSnapshotActive() ||
> + accessSharedCatalogsInDecoding ||
> + !heapRelation->rd_rel->relisshared);
> ```
>
> Not sure it's OK to use Assert(). elog(ERROR) might be better if we want to really
> avoid the case.
How about the attached?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Turn-protective-Assert-into-elog-ERROR.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2026-05-01 07:39:07 | Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables with dropped identity columns |
| Previous Message | Andreas Karlsson | 2026-05-01 07:28:28 | Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables with dropped identity columns |