Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables with dropped identity columns

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: William Bernbaum <wbernbaum(at)dwdev(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables with dropped identity columns
Date: 2026-05-01 07:39:07
Message-ID: 0b8303b1-3251-4559-8ab3-5bb5c8271d3b@proxel.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/1/26 09:28, Andreas Karlsson wrote:
> On 4/18/26 01:29, William Bernbaum wrote:
>> Patch attached.

Forgot this: Maybe it is just a bit too early in the morning and I have
not had coffee yet but I struggled a bit to apply your patch. A
recommendation for making patches easy to apply for other developers is
to generate them with the "git format-patch" command which makes them
easy to apply with "git am". You can use the "-v" flag to "git
format-patch" if you want to add a version number to the generated file
names.
Also another question worth looking into is if this same bug affects
other things, e.g. the setting of hasdefaults.

Thanks again for the patch!

--
Andreas Karlsson
Percona

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-05-01 07:50:46 Refactor code around GUC default_toast_compression
Previous Message 'Alvaro Herrera' 2026-05-01 07:30:27 Re: Adding REPACK [concurrently]