| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Maksim Logvinenko <logvinenko-ms(at)yandex(dot)ru> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix the error hint message and test for reset_shared with unknown stats type |
| Date: | 2026-04-28 23:12:04 |
| Message-ID: | afE-xDMoN3hqEjnF@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 28, 2026 at 08:18:21PM +0500, Maksim Logvinenko wrote:
> The existing error hint message and test were missing the fact that
> recently added new lock stats kind.
>
> @@ -1987,7 +1987,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS)
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("unrecognized reset target: \"%s\"", target),
> - errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
> + errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
Right, thanks for the report, Maksim. I'll fix it later.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-04-29 01:28:45 | Re: Fix race condition in XLogLogicalInfo and ProcSignal initialization. |
| Previous Message | Daniel Gustafsson | 2026-04-28 22:06:14 | Re: Changing the state of data checksums in a running cluster |