Re: Fix race condition in pg_get_publication_tables with concurrent DROP TABLE

Hi,

On Tue, Apr 28, 2026 at 07:17:00AM -0700, Bharath Rupireddy wrote:
> Hi,
>
> On Mon, Apr 27, 2026 at 10:54 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > > Sure. How about pg-get-publication-tables-after-list-built? It's 42
> > > bytes, under the INJ_NAME_MAXLEN of 64 bytes, but meaningful.
> >
> > That looks ok to me.
> >
> > Just still 2 minor comments:
> >
> > 1/
> > + # Drop the table while the SRF is paused.
> >
> > s/the SRF/ pg_get_publication_tables()/ ?
> >
> > 2/
> >
> > +# pg_get_publication_tables race with concurrent DROP TABLE.
> >
> > What about describing a bit more the bug? The other tests in 100_bugs.pl describe
> > the bug they're testing.
>
> Please find the attached v4 patch. Thank yoU!

Thanks, LGTM!

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com