From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: logical decoding and replication of sequences |
Date: | 2022-03-25 20:10:41 |
Message-ID: | af966e7d-7cfa-1a99-d315-38caa193a240@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
I've fixed most of the reported issues (or at least I think so), with
the exception of those in apply_handle_sequence function, i.e.:
1) properly coordinating with the tablesync worker
2) considering skip_lsn, skipping changes
3) missing privilege check, similar to TargetPrivilegesCheck
4) nicer error message if the sequence does not exist
The apply_handle_sequence stuff seems to be inter-related, so I plan to
deal with that in a single separate commit - the main part being the
tablesync coordination, per the fix I shared earlier today. But I need
time to think about that, I don't want to rush that.
Thanks for the feedback!
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-03-25 20:19:54 | Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error |
Previous Message | Andrew Dunstan | 2022-03-25 20:09:04 | Re: pgsql: Add 'basebackup_to_shell' contrib module. |