| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Alex Guo <guo(dot)alex(dot)hengchen(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Fix DROP PROPERTY GRAPH "unsupported object class" error |
| Date: | 2026-05-07 22:06:52 |
| Message-ID: | af0M_NSrfxUDkUeY@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 07, 2026 at 11:00:48AM +0200, Peter Eisentraut wrote:
> (But you still have the previous name in the commit message.)
(Yes, I did not bother edit the commit message.)
> I had left out these two catalogs from the object address handling
> semi-intentionally. It's not clear to me what an event trigger would want
> to do with this, or whether they should. These catalog layouts are
> implementation details, and if we expose this to event triggers, are we
> locked into this catalog layout? Do we need to document catalog changes as
> breaking user interfaces?
>
> Obviously, we shouldn't leave "unsupported object class" errors lying
> around, but I wonder whether we could also go the other way and
> intentionally skip these catalogs.
Skipping them feels a bit weird to me as objectaddress.c acts as an
interface to make a bit readable catalog dependencies. It's true that
we are in a weird spot in this representation due to the way these two
properties are stored in the catalogs, but if we can make the text
presented to the reader less confusing that seems like a benefit to
me. You have much more context than myself here, of course, so
perhaps my impression is wrong.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-05-07 22:13:05 | Re: PostgreSQL and OpenSSL 4.0.0 |
| Previous Message | Bruce Momjian | 2026-05-07 22:01:16 | Re: First draft of PG 19 release notes |