| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tomas Vondra <tv(at)fuzzy(dot)cz>, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Fix typo 586/686 in atomics/arch-x86.h |
| Date: | 2026-05-07 21:46:08 |
| Message-ID: | af0IIJQCncN3_6-v@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 07, 2026 at 04:44:45PM -0500, Nathan Bossart wrote:
> On Thu, May 07, 2026 at 10:59:26PM +0200, Daniel Gustafsson wrote:
>> Attached is a patch against HEAD for this. Reading your mail my interpretation
>> was that this was equally broken for MSVC even though the macro is correct
>> there, and we should remove both. Was that a correct reading?
>
> Yeah, atomics.h doesn't use the right macro for MSVC, so nothing in this
> file is compiled for MSVC anyway. However, I suspect the proper fix is to
> make sure this file is included for MSVC. Note that the other MSVC code in
> this file is similarly broken, but fortunately isn't used anywhere [0].
To be clear, I'm +1 on removing any 32-bit code in this file. But the
64-bit stuff should probably be fixed.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-05-07 22:00:54 | Re: Fix mismatched deallocation functions |
| Previous Message | Nathan Bossart | 2026-05-07 21:44:45 | Re: Fix typo 586/686 in atomics/arch-x86.h |