| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Henrik TJ <henrik(at)0x48(dot)dk>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix memory leak in postmasterMain |
| Date: | 2026-04-23 07:44:06 |
| Message-ID: | aenNxsSzrfbkUBlY@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 22, 2026 at 01:55:36PM -0400, Andres Freund wrote:
> If we do it, we should actually be a bit more systematic and also free
> output_config_variable.
>
> ISTM those strdup()s should actually be pstrdup()s? I suspect changing that
> would also silence valgrind.
I don't see immediately why it would not be OK to maintain this data
in the postmaster context. There is no need to rush this change on
HEAD, IMO, I'd suggest to leave that as a v20 item..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-04-23 07:55:28 | Re: Adding an explaining title to Notes on SGML |
| Previous Message | SATYANARAYANA NARLAPURAM | 2026-04-23 07:39:01 | Re: [Patch] Block ALTER TABLE RENAME COLUMN when column is used by property graph |