| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com> |
| Cc: | "'jesper(dot)pedersen(at)redhat(dot)com'" <jesper(dot)pedersen(at)redhat(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: pg_upgrade: Pass -j down to vacuumdb |
| Date: | 2019-01-25 12:00:55 |
| Message-ID: | aeea26f9-f42b-8570-9ee1-304c4f33281b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 25/01/2019 11:28, Michael Paquier wrote:
> based on that linking the value used by pg_upgrade and vacuumdb is a
> bad concept in my opinion, and the patch should be rejected. More
> documentation on pg_upgrade side to explain that a bit better could be
> a good idea though, as it is perfectly possible to use your own
> post-upgrade script or rewrite partially the generated one.
Right. pg_upgrade doesn't actually call vacuumdb. It creates a script
that you may use. The script itself contains a comment that says, if
you want to do this as fast as possible, don't use this script. That
comment could be enhanced to suggest the use of the -j option.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2019-01-25 12:01:22 | Re: backslash-dot quoting in COPY CSV |
| Previous Message | Peter Eisentraut | 2019-01-25 11:55:15 | Re: [HACKERS][PATCH] Applying PMDK to WAL operations for persistent memory |