| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Atsushi Torikoshi <atorik(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: add types to index storage params on doc |
| Date: | 2020-03-16 02:49:50 |
| Message-ID: | aee5cdd8-1663-1eb3-eb29-a886fa9d5734@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/03/16 11:09, Atsushi Torikoshi wrote:
> Hi,
>
> The current manual on CREATE TABLE[1] describes storage
> parameters with their types.
> But manual on CREATE INDEX[2] describes storage parameters
> WITHOUT their types.
>
> I think it'll be better to add types to storage parameters
> on CREATE INDEX for the consistency.
>
> Attached a patch.
> Any thought?
Thanks for the patch! It basically looks good to me.
- <term><literal>buffering</literal>
+ <term><literal>buffering</literal> (<type>string</type>)
Isn't it better to use "enum" rather than "string"?
In the docs about enum GUC parameters, "enum" is used there.
Regards,
--
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-03-16 03:04:10 | Re: backend type in log_line_prefix? |
| Previous Message | Amit Kapila | 2020-03-16 02:45:03 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |