Re: Add editorconfig support for Postgres spec files

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Tristan Partin <tristan(at)partin(dot)io>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add editorconfig support for Postgres spec files
Date: 2026-04-21 05:43:06
Message-ID: aecOai_V8w5swNhG@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 17, 2026 at 11:18:22AM +0300, Heikki Linnakangas wrote:
> src/test/isolation/specs/nowait.spec: indented with 2 spaces. But there are
> some tabs too.
>
> src/test/modules/injection_points/specs/repack_toast.spec: Tabs
>
> src/test/modules/brin/specs/summarization-and-inprogress-insertion.spec: Mix
> of tabs and spaces, width 4.
>
> Yeah, it would be nice to standardize on something...

In terms of system_views.sql, the SQL input files in the regression
test suites and the sample files, we are using whitespaces, not tabs.
I cannot say much about the width part and what would be a good
number, but at least it seems to me that the tabs should go. We don't
really have a strict width rule for the SQL files in the regression
tests, and I don't think we need one. It would be nice to keep the
same flexibility for the isolation spec files.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Soumya S Murali 2026-04-21 05:45:06 Re: Fix bug with accessing to temporary tables of other sessions
Previous Message Fujii Masao 2026-04-21 05:42:38 Re: [PATCH] Prevent repeated deadlock-check signals in standby buffer pin waits