Re: pg_rewind: warn when checkpoint hasn't happened after promotion

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: jtc331(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_rewind: warn when checkpoint hasn't happened after promotion
Date: 2023-02-27 07:33:13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 16/11/2022 07:17, kuroda(dot)keisuke(at)nttcom(dot)co(dot)jp wrote:
>> The issue here is pg_rewind looks into control file to determine the
>> soruce timeline, because the control file is not updated until the
>> first checkpoint ends after promotion finishes, even though file
>> blocks are already diverged.
>> Even in that case history file for the new timeline is already
>> created, so searching for the latest history file works.
> I think this change is a good one because if I want
> pg_rewind to run automatically after a promotion,
> I don't have to wait for the checkpoint to complete.
> The attached patch is Horiguchi-san's patch with
> additional tests. The tests are based on James's tests,
> "" tests that
> pg_rewind is successfully executed without running
> checkpoint after promote.

I fixed this last week in commit 009eeee746, see thread [1]. I'm sorry I
didn't notice this thread earlier.

I didn't realize that we had a notice about this in the docs. I'll go
and remove that. Thanks!

- Heikki

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message gamefunc 2023-02-27 07:33:50 RE: [PATCH] fix msvc build libpq error LNK2019 when link openssl;
Previous Message Peter Eisentraut 2023-02-27 07:23:34 Re: Allow tests to pass in OpenSSL FIPS mode