| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, li carol <carol(dot)li2025(at)outlook(dot)com>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, zengman <zengman(at)halodbtech(dot)com> |
| Subject: | Re: Use correct macro for accessing offset numbers. |
| Date: | 2026-04-27 23:26:44 |
| Message-ID: | ae_wtOexQA6OlY3D@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Apr 24, 2026 at 10:23:23AM +0200, Peter Eisentraut wrote:
> The thread [0] is proposing a patch to change these things in the opposite
> direction, effectively reverting commit 6dcfac9696c.
Thanks for the poke. This qualifies as an open item assigned to me, I
guess. I'll double-check the whole and reply on the other thread
where the patch has been posted at [1].
> The real problem here is that offset values that are uint32 are being output
> via the SQL type smallint, which can't handle the whole set of values, but
> this is probably not a problem in practice.
Will check all that.
[1]: https://www.postgresql.org/message-id/CAJ7c6TMcGu8qmRe1gZfJ-gOzVnZq-t%3Dfwn-UuyStx1w6ZyydMw%40mail.gmail.com
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2026-04-28 00:42:36 | Re: DOCS - typos and grammar issues across logical replication docs. |
| Previous Message | Christophe Pettus | 2026-04-27 22:51:12 | Re: uuidv7 improperly accepts dates before 1970-01-01 |