| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some extra warnings from MSVC |
| Date: | 2026-04-19 22:18:37 |
| Message-ID: | aeVUvYQ_cXgiA_j4@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 11, 2026 at 10:09:58AM -0400, Tom Lane wrote:
> I think it'd be a good idea to warn even if we can't make gcc do that.
> I think Windows is the only 64-bit platform we deal with where long
> is just 32 bits, so covering the case in MSVC will expose bugs we
> would not notice otherwise.
Interesting issue. I did not notice this thread until 9018c7d37bb4.
Please do not hesitate to add me in CC in the future, as 13b935cd521
has my fingerprints. Thanks for fixing the issue.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-04-19 23:52:58 | Re: Add bms_offset_members() function for bitshifting Bitmapsets |
| Previous Message | Michael Paquier | 2026-04-19 22:10:21 | Re: [PATCH] Add tests for Bitmapset |