Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] WIP Patch: Pgbench Serialization and deadlock errors
Date: 2018-03-26 12:15:38
Message-ID: ae993ae02a7578f70b8012b9f2ca1866@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 25-03-2018 15:23, Fabien COELHO wrote:
>> Hm, I took a look on both thread about patch and it seems to me now
>> it's overcomplicated. With recently committed enhancements of pgbench
>> (\if, \when) it becomes close to impossible to retry transation in
>> case of failure. So, initial approach just to rollback such
>> transaction looks more attractive.
>
> Yep.

Many thanks to both of you! I'm working on a patch in this direction..

> I think that the best approach for now is simply to reset (command
> zero, random generator) and start over the whole script, without
> attempting to be more intelligent. The limitations should be clearly
> documented (one transaction per script), though. That would be a
> significant enhancement already.

I'm not sure that we can always do this, because we can get new errors
until we finish the failed transaction block, and we need destroy the
conditional stack..

--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2018-03-26 12:39:51 Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types
Previous Message Kyotaro HORIGUCHI 2018-03-26 12:14:38 Re: PostgreSQL crashes with SIGSEGV