| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Richard Guo <riguo(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fast path for empty relids in check_outerjoin_delay() |
| Date: | 2019-01-04 14:32:16 |
| Message-ID: | ae987d24-51e8-d6c0-0ddd-a83b7b7c0a84@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/12/2018 08:32, Richard Guo wrote:
> This small revise is not expected to bring performance improvements, but
> can improve the readability of the code that for empty relids, the qual
> is always considered as being not-outerjoin_delayed.
I think code readability and maintainability would be improved by having
fewer special cases and fast paths. In this particular case, I'd even
remove the existing fast path and just let the subsequent loop run zero
times. I doubt there is a performance benefit to the existing coding.
And if there is no performance benefit, then it's not really a fast
path, just another path.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Klaver | 2019-01-04 14:32:59 | Re: Potentially undocumented behaviour change in Postgres 11 concerning OLD record in an after insert trigger |
| Previous Message | Tomas Vondra | 2019-01-04 14:27:38 | Re: FETCH FIRST clause PERCENT option |