Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] allow src/tools/msvc/clean.bat script to be called from the root of the source tree
Date: 2022-01-18 16:49:14
Message-ID: ae44b04a-2087-fa9d-c6b1-b1dcbbacf4ae@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 1/18/22 04:41, Juan José Santamaría Flecha wrote:
> In [1] capacity for $SUBJECT was added to most of the batch scripts,
> but clean.bat was not included. I propose to do so with the attached
> patch.

That looks a bit ugly. How about this (untested) instead?

>
> By the way, are pgbison.bat and pgflex.bat directly called anywhere?

Not to my knowledge. One of the things that's annoying about them is
that the processor names are hardcoded, so if you install winflexbison
as I usually do you have to rename the executables (or rename the
chocolatey shims) or the scripts won't work.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Attachment Content-Type Size
clean-from-anywhere.patch text/x-patch 675 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-01-18 16:53:00 Re: Push down time-related SQLValue functions to foreign server
Previous Message Peter Eisentraut 2022-01-18 16:47:37 Re: Replace uses of deprecated Python module distutils.sysconfig