Re: Always bump PG_CONTROL_VERSION?

On 5/12/21 10:04 PM, Michael Paquier wrote:
> On Wed, May 12, 2021 at 01:30:27PM -0700, Andres Freund wrote:
>> That said, I don't think it's a good practice to use the control file
>> version as an identifier for the major version. Who knows, it might be
>> necessary to add an optional new format in a minor version at some point
>> or such crazyness. And then there's the beta stuff you'd mentioned, etc.
>
> Yes, PG_VERSION, as you wrote upthread already, is already fine for
> the job, and FWIW, I have yet to see a case where being able to easily
> detect the minor version in a data folder matters.

Regardless of PG_VERSION doing the job or not, shouldn't there be a bump
in PG_CONTROL_VERSION whenever there is a structural or semantic change
in the control file data? And wouldn't the easiest way to ensure that be
to bump the version with every release?

Also, can someone give me a good reason NOT to bump the version?

Thanks, Jan

--
Jan Wieck
Postgres User since 1994