Re: OpenSSL 1.1 breaks configure and more

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Andreas Karlsson <andreas(at)proxel(dot)se>, Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>, pgsql-hackers(at)postgresql(dot)org, Christoph Berg <myon(at)debian(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: OpenSSL 1.1 breaks configure and more
Date: 2016-09-15 11:57:13
Message-ID: ae1882ba-5748-76df-26c3-6d2ade5a063a@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 09/15/2016 03:16 AM, Andreas Karlsson wrote:
> Now for a review:
>
> It looks generally good but I think I saw one error. In
> fe-secure-openssl.c your code still calls SSL_library_init() in OpenSSL
> 1.1. I think it should be enough to just call
> OPENSSL_init_ssl(OPENSSL_INIT_LOAD_CONFIG, NULL) like you do in be-secure.

Ok, fixed that, and committed. Thanks everyone!

I backpatched this to 9.5, but not further than that. The functions this
modified were moved around in 9.5, so the patch wouldn't apply as is. It
wouldn't be difficult to back-patch further if there's demand, but I'm
not eager to do that until someone complains.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-09-15 12:26:35 select_parallel test fails with nonstandard block size
Previous Message Heikki Linnakangas 2016-09-15 11:55:11 pgsql: Support OpenSSL 1.1.0.