| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Portable StaticAssertExpr |
| Date: | 2026-03-06 08:37:50 |
| Message-ID: | ae0c57e7-eb9a-4f00-9595-ebb1d7eb94fb@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 27.02.26 11:48, Jelte Fennema-Nio wrote:
> On Mon, 23 Feb 2026 at 08:00, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>> In this patch, I'm proposing a different implementation that doesn't
>> require nonstandard extensions.
>
> I tried this out in one of my WIP patches for for better C++ and it
> works correctly indeed.
Thanks, I have committed this.
> Small nit, instead of nesting ifdefs. I think this looks a bit nicer:
>
> # ifdef __cplusplus
> ...
> #elif !defined(_MSC_VER) || _MSC_VER >= 1933
> ...
> #else
> ...
> #endif
I didn't change this, because I think it is better to keep the C code
first and then the C++ as an alternate variant last (which is also
existing style, at least in some parts), even if this requires some
additional logical negations.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maciek Sakrejda | 2026-03-06 08:52:10 | Re: V18 change on EXPLAIN ANALYZE |
| Previous Message | vignesh C | 2026-03-06 08:17:06 | Re: Skipping schema changes in publication |