Re: BUG #19422: Malformed raius packet

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: stasos24(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19422: Malformed raius packet
Date: 2026-04-10 06:21:20
Message-ID: adiW4N9Boo2xUTSI@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Tue, Mar 03, 2026 at 04:20:37PM +0900, Michael Paquier wrote:
> Looking at RFC 2865, there is nothing about a limit of size for the
> attributes. This means that we are only limited by our
> RADIUS_BUFFER_SIZE. Hence, we could bump radius_attribute.length to
> uint16 and add some casts in the check for RADIUS_BUFFER_SIZE so as
> we don't overflow the addition before adding an attribute to the
> packet? On the other hand, we could aim for simpler and just reject
> any attributes larger than 255 bytes. I doubt that anybody would be
> insane enough to use fields larger than that 255 bytes anyway. Both
> solutions are equal in simplicity here.

It is worth noting that RADIUS support has been removed as of Postgres
19 in commit a1643d40b308, so I doubt that we need to take any action
here.

Or would somebody be interested enough to send a patch?
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Amit Langote 2026-04-10 06:32:31 Re: BUG: PostgreSQL 19devel throws internal opfamily error for FK with reordered referenced columns
Previous Message Amit Langote 2026-04-10 04:42:01 Re: BUG: PostgreSQL 19devel throws internal opfamily error for FK with reordered referenced columns