Re: Remove traces of long in dynahash.c

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove traces of long in dynahash.c
Date: 2025-08-27 08:00:16
Message-ID: adffbc97-cdd8-463e-96be-81d4f04b96a3@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22.08.25 07:09, Michael Paquier wrote:
> An extra thing is a suggested change for pg_nextpower2_32(), to use a
> uint64 instead of a uint32 as argument, which is caused by
> next_pow2_int64() and next_pow2_int(), that both used int64
> previously.

That seems highly confusing. What is the meaning of the "32" then?

If you need 64-bit behavior, use the variant with "64" in the name.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2025-08-27 08:22:24 Re: Adding REPACK [concurrently]
Previous Message Dmitry 2025-08-27 07:55:34 Re: Inconsistent update in the MERGE command