| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, satyanarlapuram(at)gmail(dot)com, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, tndrwang(at)gmail(dot)com |
| Subject: | Re: Add pg_stat_autovacuum_priority |
| Date: | 2026-04-09 15:23:59 |
| Message-ID: | adfEj8Bn4IWbi_wp@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 08, 2026 at 04:19:57PM -0500, Nathan Bossart wrote:
> On Wed, Apr 08, 2026 at 03:21:38PM -0400, Tom Lane wrote:
>> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>>> FWIW that elog() shouldn't be emitting anything from the view, unless
>>> something is broken.
>>
>> [ looks again... ] Oh, you mean because pg_stat_get_autovacuum_scores
>> passes 0 for elevel instead of any of the valid elevel constants.
>> Can you say "undocumented cowboy hack"? I'd be happier if we added
>> something like "#define LOG_NEVER 0 /* Never emit this message */"
>> to elog.h and used that.
>
> Yeah... I should've done that originally. Here's a patch that I'll apply
> in the next day or so, barring objections.
Committed. Working on Sami's patch next.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniil Davydov | 2026-04-09 15:29:52 | Re: Fix bug with accessing to temporary tables of other sessions |
| Previous Message | Alexander Korotkov | 2026-04-09 15:21:24 | Re: Implement waiting for wal lsn replay: reloaded |