Re: Is it useful to record whether plans are generic or custom?

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp, sunchengxi(at)highgo(dot)com, pgsql-hackers(at)postgresql(dot)org, pavel(dot)stehule(at)gmail(dot)com, legrand_legrand(at)hotmail(dot)com
Subject: Re: Is it useful to record whether plans are generic or custom?
Date: 2021-04-05 09:01:48
Message-ID: add1e591fbe8874107e75d04328859ec@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-03-26 17:46, Fujii Masao wrote:
> On 2021/03/26 0:33, torikoshia wrote:
>> On 2021-03-25 22:14, Fujii Masao wrote:
>>> On 2021/03/23 16:32, torikoshia wrote:
>>>> On 2021-03-05 17:47, Fujii Masao wrote:
>>>>
>>>> Thanks for your comments!
>>>
>>> Thanks for updating the patch!
>>>
>>> PostgreSQL Patch Tester reported that the patched version failed to
>>> be compiled
>>> at Windows. Could you fix this issue?
>>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.131238
>>>
>>
>> It seems PGDLLIMPORT was necessary..
>> Attached a new one.
>
> Thanks for updating the patch!
>
> In my test, generic_calls for a utility command was not incremented
> before PL/pgSQL function was executed. Maybe this is expected behavior.
> But it was incremented after the function was executed. Is this a bug?
> Please see the following example.

Thanks for reviewing!

It's a bug and regrettably it seems difficult to fix it during this
commitfest.

Marked the patch as "Withdrawn".

Regards,

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-04-05 09:29:14 Re: shared-memory based stats collector
Previous Message Etsuro Fujita 2021-04-05 08:15:47 Re: Asynchronous Append on postgres_fdw nodes.