| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add COMMENT and SECURITY LABEL support for publications and subs |
| Date: | 2017-04-14 02:48:48 |
| Message-ID: | adbb39eb-bad0-6663-34b6-b52f37eb922f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 4/4/17 09:59, Stephen Frost wrote:
>> Attached is a patch that adds the pg_dump support, but I'm struggling to
>> make the tests work. Could you take a look? Problem one I'm seeing is
>> that the tests assert that there are no comments in the post-data
>> section, which is no longer the case here.
>
> If that's the case (and is intended), then you'll need to remove the
> 'section_post_data' entry from the COMMENTS catch-all 'unlike' and move
> that into the 'unlike' for each of the COMMENT tests which were
> depending on the catch-all to handle that.
done
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-04-14 03:22:33 | pgsql: Remove trailing spaces in some output |
| Previous Message | Peter Eisentraut | 2017-04-14 02:47:26 | pgsql: pg_dump: Dump comments and security labels for publication and s |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-04-14 03:49:16 | Re: [PATCH] Remove trailing spaces |
| Previous Message | Michael Paquier | 2017-04-14 02:42:52 | Re: Letting the client choose the protocol to use during a SASL exchange |