| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Patch for bug #17056 fast default on non-plain table |
| Date: | 2021-06-17 15:13:10 |
| Message-ID: | adb8d13a-75e2-e4b7-dff8-eb3ea12d03b3@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/17/21 11:05 AM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Here's a patch I propose to apply to fix this bug (See
>> <https://www.postgresql.org/message-id/flat/759e997e-e1ca-91cd-84db-f4ae963fada1%40dunslane.net#b1cf11c3eb1f450bed97c79ad473909f>)
> If I'm reading the code correctly, your change in RelationBuildTupleDesc
> is scribbling directly on the disk buffer, which is surely not okay.
> I don't understand why you need that at all given the other defenses
> you added ... but if you need it, you have to modify the tuple AFTER
> copying it.
OK, will fix. I think we do need it (See Andres' comment in the bug
thread). It should be a fairly simple fix.
Thanks for looking.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2021-06-17 15:14:11 | Re: Iterating on IndexTuple attributes and nbtree page-level dynamic prefix truncation |
| Previous Message | Tom Lane | 2021-06-17 15:05:38 | Re: Patch for bug #17056 fast default on non-plain table |