Re: updates for handling optional argument in system functions

On Wed, Apr 08, 2026 at 01:51:30AM +0200, Andreas Karlsson wrote:
> On 4/8/26 1:42 AM, Mark Wong wrote:
> > I don't see any matches when I grep for rule_oid or pretty_bool...
>
> Sorry for the noise, I was looking at an old version of the docs. The
> parameters do indeed match the docs. But now that I looked at the
> patches again I found a real issue which I think should be fixed.

No worries.

> I think the following:
>
> "select statement of a view with pretty-print option"
>
> should likely just be:
>
> "select statement of a view"

Yeah, I agree with that considering that other functions like the recent
get_*_ddl functions have options like that aren't detailed in
pg_proc.dat.

What I pondered over a little bit was whether to flip-flop and remove
the original _ext definitions instead and modify their respective
counterparts that I originally removed. I opted to continue editing what
I started because of the comment that reads "System-view support
functions with pretty-print option", but I don't have any strong
opinions either way.

I've attached v7 with the more succinct descriptions.

Regards,
Mark