| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Shmem allocated wrong for custom cumulative stats |
| Date: | 2026-04-07 03:04:35 |
| Message-ID: | adR0Q9NO2jbLiQuM@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 06, 2026 at 12:14:06PM +0900, Michael Paquier wrote:
> The attached is working correctly. The v18 flavor is slightly
> simpler.
I have looked at it again today, and noticed that the test modules of
both HEAD and REL_18_STABLE were incorrect in the values they set for
shared_size for the fixed-sized cases. In both cases we were
finishing with an underestimation. I could only see a direct impact
on HEAD for the 32-bit builds, though, but the problem was the same.
The allocation has been fixed in 17132f55c5a2, with the modules
handled by 98979578055f.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-04-07 03:07:45 | Re: Implement waiting for wal lsn replay: reloaded |
| Previous Message | Fujii Masao | 2026-04-07 03:04:12 | Re: pgsql: Reduce log level of some logical decoding messages from LOG to D |