Re: vectorized CRC on ARM64

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: vectorized CRC on ARM64
Date: 2026-04-04 14:36:58
Message-ID: adEiCi5gHvN4XTp-@nathan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 04, 2026 at 08:52:34PM +0700, John Naylor wrote:
> Thanks for looking! Pushed with a minor comment tweak and removal of
> the CFLAGS save-and-restore dance since we don't need it anymore.
> Let's see what the buildfarm thinks.

Ha, I think koel is going to complain about your comment that talks about
pgindent...

diff --git a/src/port/pg_crc32c_armv8.c b/src/port/pg_crc32c_armv8.c
index b404e6c373e..5fa57fb4927 100644
--- a/src/port/pg_crc32c_armv8.c
+++ b/src/port/pg_crc32c_armv8.c
@@ -162,8 +162,8 @@ pg_comp_crc32c_pmull(pg_crc32c crc, const void *data, size_t len)
}

/*
- * pgindent complained of unmatched parens, so the following has
- * been re-written with intrinsics:
+ * pgindent complained of unmatched parens, so the following has been
+ * re-written with intrinsics:
*
* x0 = veorq_u64((uint64x2_t) {crc0, 0}, x0);
*/

--
nathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-04-04 14:38:53 Re: TupleDescAttr bounds checks
Previous Message Nathan Bossart 2026-04-04 14:33:43 Re: Add pg_stat_autovacuum_priority