Re: PoC/WIP: Extended statistics on expressions

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PoC/WIP: Extended statistics on expressions
Date: 2021-01-22 03:49:51
Message-ID: acf27932-8159-8872-8fca-902c7a35b351@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 1/22/21 3:29 AM, Justin Pryzby wrote:
> This already needs to be rebased on 55dc86eca.
>
> And needs to update rules.out.
>

Whooops. A fixed version attached.

> And doesn't address this one:
>
> On Sun, Jan 17, 2021 at 10:53:31PM -0600, Justin Pryzby wrote:
>> | postgres=# CREATE TABLE t(i int);
>> | postgres=# CREATE STATISTICS s2 ON (i+1) ,(i+1+0) FROM t;
>> | postgres=# \d t
>> | Table "public.t"
>> | Column | Type | Collation | Nullable | Default
>> | --------+---------+-----------+----------+---------
>> | i | integer | | |
>> | Indexes:
>> | "t_i_idx" btree (i)
>> | Statistics objects:
>> | "public"."s2" (ndistinct, dependencies, mcv) ON FROM t
>>
>> on ... what ?
>

Umm, for me that prints:

test=# CREATE TABLE t(i int);
CREATE TABLE
test=# CREATE STATISTICS s2 ON (i+1) ,(i+1+0) FROM t;
CREATE STATISTICS
test=# \d t
Table "public.t"
Column | Type | Collation | Nullable | Default
--------+---------+-----------+----------+---------
i | integer | | |
Statistics objects:
"public"."s2" ON ((i + 1)), (((i + 1) + 0)) FROM t

which I think is OK. But maybe there's something else to trigger the
problem?

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
0001-bootstrap-convert-Typ-to-a-List-20210122b.patch text/x-patch 3.7 KB
0002-Allow-composite-types-in-bootstrap-20210122b.patch text/x-patch 1.4 KB
0003-Extended-statistics-on-expressions-20210122b.patch text/x-patch 246.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-01-22 04:01:01 Re: PoC/WIP: Extended statistics on expressions
Previous Message tsunakawa.takay@fujitsu.com 2021-01-22 03:34:42 RE: libpq debug log