Re: fix: propagate M4 env variable to flex subprocess

On 17.06.25 07:15, Peter Eisentraut wrote:
> On 28.05.25 20:42, J. Javier Maestro wrote:
>> On Wed, May 28, 2025 at 6:08 PM Andres Freund <andres(at)anarazel(dot)de
>> <mailto:andres(at)anarazel(dot)de>> wrote:
>>
>>     Hi,
>>
>>     On 2025-05-17 23:32:24 -0400, J. Javier Maestro wrote:
>>      > On Tue, May 13, 2025 at 11:54 AM Andres Freund
>>     <andres(at)anarazel(dot)de <mailto:andres(at)anarazel(dot)de>> wrote:
>>      > > Bilal, I think you wrote this originally, do you recall?
>>      > >
>>      > > It seems like an issue beyond just M4...
>>      > >
>>      >
>>      > IIRC the rest of the tools in the environment have ways to be
>>     specified via
>>      > Meson options (BISON, FLEX, PERL) so the only issue I see is Flex
>>     not being
>>      > able to find the specific m4 binary. What other issue(s) are you
>>      > considering?
>>
>>     PATH, LD_LIBRARY_PATH, ...
>>
>>     I think this really should just add to the environment, rather than
>>     supplant
>>     it.
>>
>>
>> Ah, understood. That definitely looks like a better option.
>>
>>     Do you want to write a patch like that? Otherwise I can.
>>
>>
>> Sure, I've attached the new patch. Let me know what you think, and if
>> it's OK, what are the next steps to get the patch merged in main!
>
> This patch looks right to me.
>
> I would wait for the PG19 branching at this point, unless there is a
> concrete need for backpatching.

committed