| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Code quality issues in ICU patch |
| Date: | 2017-06-30 12:13:44 |
| Message-ID: | accde5ce-6421-1ea8-842c-dbcb5644d462@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/24/17 11:51, Tom Lane wrote:
> Ah, I was about to suggest the same thing, but I was coming at it from
> the standpoint of not requiring buffers several times larger than
> necessary, which could in itself cause avoidable palloc failures.
>
> I was going to suggest a small variant actually: run the conversion
> function an extra time only if the string is long enough to make the
> space consumption interesting, say
I had thought about something like that, too, but my concern is that we
then have double the code paths to test. I have run some performance
tests and I couldn't detect any differences between the variants. So
unless someone has any other insights, I think I'll go with the proposed
patch by tomorrow.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Ladhe | 2017-06-30 12:18:53 | Re: Adding support for Default partition in partitioning |
| Previous Message | Craig Ringer | 2017-06-30 12:10:03 | Re: [HACKERS] Postgres process invoking exit resulting in sh-QUIT core |