| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, shihao zhong <zhong950419(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixes inconsistent behavior in vacuum when it processes multiple relations |
| Date: | 2026-03-26 16:07:52 |
| Message-ID: | acVZ2O0938nWa73w@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 26, 2026 at 11:22:25AM +0900, Michael Paquier wrote:
> Once vacuum_rel() has its VacuumParams changed to a pointer, renaming
> it to params_local and use params_local in all its code paths looks
> sensible. On top of what you are doing, I would add a big warning
> comment at the top of the routine to mention that "params" should not
> be used directly in the routine. The local copies should be used.
Wait... Can't we just pass params by value only to vacuum_rel()? Doesn't
this accomplish what we need?
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-avoid-including-vacuum.h-in-tableam.h-and-heapam..patch | text/plain | 27.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-26 16:29:46 | Re: [PATCH] pgindent truncates last line of files missing a trailing newline |
| Previous Message | Tomas Vondra | 2026-03-26 16:07:41 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |