| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, shihao zhong <zhong950419(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fixes inconsistent behavior in vacuum when it processes multiple relations |
| Date: | 2026-03-25 15:33:48 |
| Message-ID: | acQAXPXov4cbyUx0@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 24, 2026 at 11:29:52PM -0400, Andres Freund wrote:
> On 2026-03-24 16:47:30 -0500, Nathan Bossart wrote:
>> + VacuumParams params_copy;
>
> I'd maybe not name it _copy, but params_local or params_table or such, as
> somehow it seems a bit odd to modify the copy. But I can't really explain why
> it feels odd.
params_local WFM.
> I wonder if more of the code in the function should be updated to use the
> copy, otherwise it seems like it could more easily happen that a part of the
> code not using the modified version is moved until after a modification, and
> the code author assumes the modifications now have taken effect.
Yeah, I was waffling on this. I updated the rest of the function to use
params_local instead.
--
nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-avoid-including-vacuum.h-in-tableam.h-and-heapam..patch | text/plain | 35.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yamaguchi Atsuo | 2026-03-25 15:43:58 | Re: Add tab completion for SERVER and CONNECTION keywords in psql |
| Previous Message | Melanie Plageman | 2026-03-25 15:33:08 | Re: Don't synchronously wait for already-in-progress IO in read stream |